8000 [CI] Skip tests on doc-only changes by greglucas · Pull Request #25261 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

[CI] Skip tests on doc-only changes #25261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jklymak merged 1 commit into from
Feb 20, 2023
Merged

[CI] Skip tests on doc-only changes #25261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
8000
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ on:
pull_request:
branches-ignore:
- v[0-9]+.[0-9]+.[0-9x]+-doc
paths-ignore:
# Skip running tests if changes are only in documentation directories
- 'doc/**'
- 'examples/**'
- 'plot_types/**'
- 'tutorials/**'
Copy link
Member
@jklymak jklymak Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add plot_types. Note if we get #25209 in we can just test on "galleries/**"

Copy link
Contributor Author
@greglucas greglucas Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We can add more later no problem. I guess an alternative question for the future is whether we really want these at the top-level of the repository versus living under doc/galleries, doc/plot_types etc... which would then allow just doc/** to be ignored.

Copy link
Member
@jklymak jklymak Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to do that because then sphinx will try and process them and it will be confusing what the source and result of sphinx-gallery processing them is. However, getting them under one subdirectory at the top level is the goal of #25209

Copy link
Contributor Author
@greglucas greglucas Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I see. I have not been following the docs reorganization. That does seem like a nice change!

schedule:
# 5:47 UTC on Saturdays
- cron: "47 5 * * 6"
Expand Down
0