8000 Add locator API links to tick-locators example by nox1134 · Pull Request #25177 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Add locator API links to tick-locators example #25177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 10, 2023
Merged

Add locator API links to tick-locators example #25177

merged 5 commits into from
Feb 10, 2023

Conversation

nox1134
Copy link
Contributor
@nox1134 nox1134 commented Feb 8, 2023 •
edited
Loading

Signed-off-by: priyanshi noxdot1134@gmail.com
Fixes #25172

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@nox1134
Add locator API links to tick-locators example
2aaaa14 
Signed-off-by: priyanshi <noxdot1134@gmail.com>
story645
story645 reviewed Feb 8, 2023
View reviewed changes
Copy link
Member
@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, can you also please add the set_minor and set_major functions to the list?

@nox1134
Resolve flake8 warning: remove trailing white space at the end of tic…
b9ee17e 
…k-locators.py

Signed-off-by: priyanshi <noxdot1134@gmail.com>
github-actions[bot]
github-actions bot reviewed Feb 8, 2023
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@nox1134
Added set_minor and set_major functions to the references section in …
71fae50 
…tick-locators.py

Signed-off-by: priyanshi <noxdot1134@gmail.com>
@nox1134 nox1134 requested a review from story645 February 8, 2023 21:54
ksunden
ksunden reviewed Feb 9, 2023
View reviewed changes
examples/ticks/tick-locators.py Outdated
# - `matplotlib.ticker.AutoLocator`
# - `matplotlib.ticker.MaxNLocator`
# - `matplotlib.ticker.LogLocator`
# %%
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# %%

Pretty sure this line is causing the sphinx build to error

A quick survey of other similar references section this closing %% is not included

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing that out! I will remove the closing '%%' and test the build again. I appreciate your help.

@nox1134
fixed the error
342f1e2 
Signed-off-by: priyanshi <noxdot1134@gmail.com>
@nox1134 nox1134 requested review from ksunden and removed request for story645 February 9, 2023 02:35
story645
story645 reviewed Feb 9, 2023
View reviewed changes
@nox1134
Removed XAxis and YAxis set_ticks_position
89c9736 
Signed-off-by: priyanshi <noxdot1134@gmail.com>
@nox1134 nox1134 requested review from story645 and removed request for ksunden February 9, 2023 16:49
dstansby
dstansby approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member
@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this, and congrats you your first PR to Matplotlib 🎉

@dstansby dstansby merged commit 573292d into matplotlib:main Feb 10, 2023
@dstansby dstansby added this to the v3.8.0 milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksunden ksunden ksunden left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@dstansby dstansby dstansby approved these changes

@story645 story645 Awaiting requested review from story645

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

[Doc]: cross link locator example with locator API
4 participants
@nox1134 @story645 @ksunden @dstansby
0