8000 Fix argument checking in `Axes3D.quiver` by oscargus · Pull Request #24862 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix argument checking in Axes3D.quiver #24862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2023
Merged

Fix argument checking in Axes3D.quiver #24862

merged 1 commit into from
Jan 3, 2023

Conversation

oscargus
Copy link
Member
@oscargus oscargus commented Jan 1, 2023

PR Summary

Closes #24842

I am not sure if anything else is required here. It seems like explicitly listing the six positional arguments is the sensible thing to do. It was previously possible to pass more arguments, that option was
removed in #23076 (and deprecated earlier), although the consequence here was probably not handled/foreseen.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

8000
@oscargus oscargus mentioned this pull request Jan 1, 2023
Closed
@oscargus oscargus added this to the v3.7.0 milestone Jan 1, 2023
timhoffm
timhoffm reviewed Jan 2, 2023
View reviewed changes
@ksunden ksunden merged commit 891bacf into matplotlib:main Jan 3, 2023
@oscargus oscargus deleted the quiver3dfix branch January 4, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm left review comments

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
topic: mplot3d
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

axes3d.quiver() fails when providing args to Line3DCollection
4 participants
@oscargus @timhoffm @dstansby @ksunden
0