10000 Run delvewheel on Windows for wheels by QuLogic · Pull Request #24724 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Run delvewheel on Windows for wheels #24724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2022
Merged

Run delvewheel on Windows for wheels #24724

merged 1 commit into from
Dec 20, 2022

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Dec 14, 2022 •
edited
Loading

PR Summary

This causes the MSVC runtime to be bundled, which enables importing Matplotlib on systems that do not have it installed.

Fixes #24704.

PR Checklist

Documentation and Tests

  • [n/a] Has pytest style unit tests (and pytest passes)
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@QuLogic QuLogic added OS: Microsoft CI: Run cibuildwheel Run wheel building tests on a PR labels Dec 14, 2022
@tacaswell tacaswell added this to the v3.7.0 milestone Dec 14, 2022
@QuLogic QuLogic mentioned this pull request Dec 15, 2022
Closed
@tacaswell tacaswell marked this pull request as ready for review December 16, 2022 20:55
tacaswell
tacaswell approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member
@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #24704 (comment) this is working.

@ksunden ksunden merged commit b6c2738 into matplotlib:main Dec 20, 2022
@QuLogic QuLogic deleted the windows-delvewheel branch December 20, 2022 05:56
@QuLogic QuLogic mentioned this pull request Jan 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@ksunden ksunden ksunden approved these changes

Assignees
No one assigned
Labels
CI: Run cibuildwheel Run wheel building tests on a PR OS: Microsoft
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

[Bug]: ImportError: DLL load failed on Windows
3 participants
@QuLogic @tacaswell @ksunden
0