BUG: Fix bug with mutable input modification #24657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Dec 7, 2022
jklymak
approved these changes
Dec 7, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 7, 2022
tacaswell
added a commit
that referenced
this pull request
Dec 7, 2022
…657-on-v3.6.x Backport PR #24657 on branch v3.6.x (BUG: Fix bug with mutable input modification)
QuLogic
added a commit
to QuLogic/mplcairo
that referenced
this pull request
Jan 21, 2023
A similar thing was done upstream in matplotlib/matplotlib#24657 and the test for it is now failing because mplcairo also modified input.
anntzer
pushed a commit
to matplotlib/mplcairo
that referenced
this pull request
Jan 21, 2023
A similar thing was done upstream in matplotlib/matplotlib#24657 and the test for it is now failing because mplcairo also modified input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
On
main,imsave(and thusfig.savefig) modifies the mutablepil_kwargswithout making a copy. The modified tests fail onmainbut pass on this PR.PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst