8000 [Doc] Fix spelling and grammar in tutorials by oscargus · Pull Request #24526 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

[Doc] Fix spelling and grammar in tutorials #24526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2022
Merged

[Doc] Fix spelling and grammar in tutorials #24526

merged 1 commit into from
Dec 10, 2022

Conversation

oscargus
Copy link
Member

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

story645
story645 reviewed Nov 21, 2022
View reviewed changes
Copy link
Member
@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little unsure of the x-axis convention

@oscargus
Copy link
Member Author

Got back to this now, so please have another look. Thanks for the comments!

@oscargus oscargus added this to the v3.6-doc milestone Dec 10, 2022
@timhoffm timhoffm merged commit 6649511 into matplotlib:main Dec 10, 2022
@lumberbot-app
Copy link
lumberbot-app bot commented Dec 10, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 6649511e2b75badc2255d83e232c0f2613c90fd5
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24526: [Doc] Fix spelling and grammar in tutorials'
  1. Push to a named branch:
git push YOURFORK v3.6.x:auto-backport-of-pr-24526-on-v3.6.x
  1. Create a PR against branch v3.6.x, I would have named this PR:

"Backport PR #24526 on branch v3.6.x ([Doc] Fix spelling and grammar in tutorials)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@lumberbot-app
Copy link
lumberbot-app bot commented Dec 10, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.2-doc
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 6649511e2b75badc2255d83e232c0f2613c90fd5
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24526: [Doc] Fix spelling and grammar in tutorials'
  1. Push to a named branch:
git push YOURFORK v3.6.2-doc:auto-backport-of-pr-24526-on-v3.6.2-doc
  1. Create a PR against branch v3.6.2-doc, I would have named this PR:

"Backport PR #24526 on branch v3.6.2-doc ([Doc] Fix spelling and grammar in tutorials)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@oscargus oscargus deleted the tutorialspelling branch December 12, 2022 08:00
@QuLogic QuLogic modified the milestones: v3.6-doc, v3.7.0 Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@story645 story645 story645 left review comments

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@oscargus @story645 @timhoffm @QuLogic
0