8000 [DOC] swapped params in fig_compare_error msg by story645 · Pull Request #24467 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

[DOC] swapped params in fig_compare_error msg #24467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2022
Merged

[DOC] swapped params in fig_compare_error msg #24467

merged 1 commit into from
Nov 15, 2022

Conversation

story645
Copy link
Member

Swapped fig_ref and fig_test in the error message so that it'd match the order in the function signature. Technically I think order doesn't matter since it's done by signature, but I think having them in the same order slightly reduces friction.

@ksunden ksunden merged commit 24fba58 into matplotlib:main Nov 15, 2022
@story645 story645 deleted the dep branch November 16, 2022 00:07
@QuLogic QuLogic added this to the v3.7.0 milestone Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksunden ksunden ksunden approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation topic: testing
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@story645 @ksunden @timhoffm @QuLogic
0