made f2tfont error message explicit that it needs path to file #24415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests match against that portion of the error message, so tests also need to be updated |
|
:/ ugh I only checked the f2tfont tests and I guess not carefully enough 😖 |
Co-authored-by: Kyle Sunden <git@ksunden.space>
|
One more: Edit: Ah, must of looked at an old CI run... because that is in fact the one you fixed up Double edit: it is in fact still that test that is erroring, missing |
ksunden
reviewed
Nov 10, 2022
Co-authored-by: Kyle Sunden <git@ksunden.space>
|
this is why coding while 😪 is uh not the best idea - thanks for your patience/help here! |
QuLogic
approved these changes
Nov 10, 2022
ksunden
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per conversation on gitter, I was trying to add fonts and thought I could pass in the path to the folder of fonts cause the docs say path, so I wanted to make it a bit clearer that path means path to file.