8000 Inline AnchoredOffsetBox._update_offset_func. by anntzer · Pull Request #23896 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Inline AnchoredOffsetBox._update_offset_func. #23896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2022
Merged

Inline AnchoredOffsetBox._update_offset_func. #23896

merged 1 commit into from
Sep 15, 2022

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Sep 15, 2022

It is only called in get_window_extent -- and in draw, but that call is immediately followed by a call to get_window_extent, so it is redundant.

Split out of #21699; this change should be less controversial than the rest of that PR.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer
Inline AnchoredOffsetBox._update_offset_func.
ad94907 
It is only called in `get_window_extent` -- and in `draw`, but *that*
call is immediately followed by a call to `get_window_extent`, so it is
redundant.
@oscargus oscargus added this to the v3.7.0 milestone Sep 15, 2022
@oscargus oscargus merged commit 5c45952 into matplotlib:main Sep 15, 2022
@anntzer anntzer deleted the uof branch September 15, 2022 20:59
@anntzer anntzer mentioned this pull request Nov 1, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @oscargus
0