8000 Allow any color format to be used for axis3d.Axis.set_pane_color by oscargus · Pull Request #23647 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Allow any color format to be used for axis3d.Axis.set_pane_color #23647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 17, 2022
Merged

Allow any color format to be used for axis3d.Axis.set_pane_color #23647

merged 3 commits into from
Aug 17, 2022

Conversation

oscargus
Copy link
Member

PR Summary

There are three distinct commits in this PR:

  1. Deprecate set_pane_pos: the set value is not used and overwritten at draw time, so should not be public.
  2. Simplify the pane creation (removed properties overwritten anyway)
  3. Allow any color to be used when setting pane color.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus
Copy link
Member Author

One may consider deprecating draw_pane as well and make it a private method. I cannot really see why a user would like to trigger the pane drawing separately.

@tacaswell tacaswell added this to the v3.6.0 milestone Aug 17, 2022
@tacaswell tacaswell merged commit 285adc5 into matplotlib:main Aug 17, 2022
@oscargus oscargus deleted the mplot3dfixes branch August 17, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
API: changes topic: mplot3d
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oscargus @timhoffm @tacaswell
0