8000 Fix sgskip'd examples by QuLogic · Pull Request #23495 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix sgskip'd examples #23495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 30, 2022
Merged

Fix sgskip'd examples #23495

merged 5 commits into from
Jul 30, 2022

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Jul 28, 2022

PR Summary

Some do not run, and some have minor breakage.

examples/user_interfaces/embedding_webagg_sgskip.py is also broken due to some manager/canvas API change, but I'm not sure how to fix; cc @anntzer.

PR Checklist

Tests and Styling

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic QuLogic added this to the v3.6.0 milestone Jul 28, 2022
@anntzer anntzer mentioned this pull request Jul 28, 2022
Merged
6 tasks
QuLogic added 5 commits July 29, 2022 17:15
@QuLogic
Fix image thumbnail example
009021f
@QuLogic
Fix import in wx example
ed37d4f
@QuLogic
Fix the Fourier in WX demo
2117bab 
WX crashes if EXPAND is passed with an alignment option.
@QuLogic
Fix deprecation warnings from GTK examples
800703a
@QuLogic
Remove function menu from wxGTK mathtext example
c677fa9 
GTK no longer defaults to showing images in menus, unless they are set
to important. However, wx does not appear to expose that setting, so it
just produces a menu of blank options.
@timhoffm timhoffm merged commit cd66bfd into matplotlib:main Jul 30, 2022
@QuLogic QuLogic deleted the fix-sgskip branch July 30, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@QuLogic @timhoffm
0