8000 Deprecate properties w_xaxis, w_yaxis, and w_zaxis by oscargus · Pull Request #23455 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Deprecate properties w_xaxis, w_yaxis, and w_zaxis #23455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2022
Merged

Deprecate properties w_xaxis, w_yaxis, and w_zaxis #23455

merged 1 commit into from
Jul 21, 2022

Conversation

oscargus
Copy link
Member
@oscargus oscargus commented Jul 20, 2022 •
edited
Loading

PR Summary

Originally deprecated in #11387.

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus force-pushed the 3daxisdeprecations branch from 74cb9eb to 80c1998 Compare July 20, 2022 20:26
@oscargus oscargus marked this pull request as ready for review July 20, 2022 20:44
@QuLogic
Copy link
Member
QuLogic commented Jul 20, 2022

@timhoffm suggested removal in 4.0; not sure if that's still the suggested time frame.

@oscargus
Copy link
Member Author
oscargus commented Jul 21, 2022 •
edited
Loading

Yeah, I noted that when digging up the original PR. Will change accordingly once a timeline is determined.

(Have sorted out the doc issue locally, but no point to trigger another CI before knowing the version.)

@tacaswell tacaswell added this to the v3.6.0 milestone Jul 21, 2022
QuLogic
QuLogic reviewed Jul 21, 2022
View reviewed changes
@oscargus oscargus force-pushed the 3daxisdeprecations branch from 80c1998 to 496fa50 Compare July 21, 2022 19:41
@timhoffm timhoffm merged commit 4259c18 into matplotlib:main Jul 21, 2022
@oscargus oscargus deleted the 3daxisdeprecations branch July 22, 2022 12:49
@alsaibie alsaibie mentioned this pull request Jan 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance topic: mplot3d
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@oscargus @QuLogic @tacaswell @timhoffm
0