8000 Combine chunk size tests into one by QuLogic · Pull Request #23413 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Combine chunk size tests into one #23413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2022
Merged

Combine chunk size tests into one #23413

merged 1 commit into from
Jul 12, 2022

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Jul 11, 2022

PR Summary

Each one allocates over 2G, and are right next to each other, so when running in parallel, they can combine to OOM very easily. It would be nice to drop the large memory usage entirely, but at least we can remove 5 extra copies of it.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic
Combine chunk size tests into one
534af5a 
Each one allocates over 2G, and are right next to each other, so when
running in parallel, they can combine to OOM very easily. It would be
nice to drop the large memory usage entirely, but at least we can remove
5 extra copies of it.
@QuLogic QuLogic added this to the v3.6.0 milestone Jul 11, 2022
@oscargus oscargus merged commit dc163ca into matplotlib:main Jul 12, 2022
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Jul 12, 2022
@timhoffm
Add a note why test_chunksize_fails() covers multiple test scenarios
cd31e3a 
Follow-up to matplotlib#23413.
@timhoffm timhoffm mentioned this pull request Jul 12, 2022
Merged
@QuLogic QuLogic deleted the merge-large-tests branch July 12, 2022 21:50
oscargus pushed a commit to oscargus/matplotlib that referenced this pull request Jul 20, 2022
@QuLogic @oscargus
Combine chunk size tests into one (matplotlib#23413)
3c85bf3 
Each one allocates over 2G, and are right next to each other, so when
running in parallel, they can combine to OOM very easily. It would be
nice to drop the large memory usage entirely, but at least we can remove
5 extra copies of it.
oscargus pushed a commit to oscargus/matplotlib that referenced this pull request Jul 20, 2022
@timhoffm @oscargus
Add a note why test_chunksize_fails() covers multiple test scenarios
0c2ba44 
Follow-up to matplotlib#23413.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
Performance topic: testing
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @anntzer @oscargus
0