8000 Link 3D animation examples to one another. by anntzer · Pull Request #23402 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Link 3D animation examples to one another. #23402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2022
Merged

Link 3D animation examples to one another. #23402

merged 1 commit into from
Jul 8, 2022

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jul 8, 2022

Also use double quotes in English text.
Also inline definition of Z array; it's not as the docstring of
generate() was helpful at all.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

timhoffm
timhoffm approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module fixing the links.

examples/mplot3d/rotate_axes3d_sgskip.py Outdated
@@ -5,7 +5,7 @@

A very simple animation of a rotating 3D plot about all 3 axes.

See wire3d_animation_demo for another simple example of animating a 3D plot.
See :doc:`wire3d_animation_demo` for another example of animating a 3D plot.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to specify the relative path /gallery/section/file

https://matplotlib.org/devdocs/devel/documenting_mpl.html#referring-to-other-documents-and-sections

@anntzer
Link 3D animation examples to one another.
02b07ef 
Also use double quotes in English text.
Also inline definition of Z array; it's not as the docstring of
generate() was helpful at all.
@anntzer
Copy link
Contributor Author
anntzer commented Jul 8, 2022

thanks, fixed.

@timhoffm timhoffm added this to the v3.6.0 milestone Jul 8, 2022
@timhoffm timhoffm merged commit 5988611 into matplotlib:main Jul 8, 2022
@anntzer anntzer deleted the 3de branch July 8, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation topic: animation topic: mplot3d
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @timhoffm
0