8000 Deprecate unused methods in axis.py by oscargus · Pull Request #23190 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Deprecate unused methods in axis.py #23190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2022
Merged

Deprecate unused methods in axis.py #23190

merged 1 commit into from
Jun 15, 2022

Conversation

oscargus
Copy link
Member
@oscargus oscargus commented Jun 2, 2022 •
edited
Loading

PR Summary

These methods were introduced in 66290aa to be used in update_layout. I have not figured out when update_layout was removed, but the methods have probably been unused (from the codebase) since.

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus added this to the v3.6.0 milestone Jun 2, 2022
@oscargus oscargus force-pushed the deprecationsinaxis branch from b76402f to 443a3e2 Compare June 3, 2022 07:16
@oscargus oscargus marked this pull request as ready for review June 3, 2022 07:17
@oscargus oscargus force-pushed the deprecationsinaxis branch from 443a3e2 to cca40bc Compare June 3, 2022 08:05
@timhoffm timhoffm merged commit 5dbc3b1 into matplotlib:main Jun 15, 2022
@oscargus oscargus deleted the deprecationsinaxis branch June 15, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
API: changes Maintenance topic: ticks axis labels
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oscargus @QuLogic @timhoffm
0