Fix width/height inversion in dviread debug helper. #23087
Conversation
`python -mmatplotlib.dviread` is useful to verify how matplotlib parses dvi constructs, but the output inverted the width and height of boxes.
There was a problem hiding this comment.
I don't claim to understand anything of dvi.
This currently prints a list and the header ("w", "h") is consistent with the content. However I agree that it's inverse to the definition in boxes. So the question is: Are these boxes and their order a known concept? If they are only an implementation detail, I would not change this. The order (width, height) is more common and we need a good reason to not use that for display.
|
Right now the main problem is that the headers ("w", "h") don't match the contents, because the unpack ( As for whether to print width or height first, it's probably not a huge deal either way but note that dvi specifies the height of boxes first (https://tug.org/TUGboat/Articles/tb03-2/tb06software.pdf opcode 132 set_rule). |
python -mmatplotlib.dvireadis useful to verify how matplotlib parsesdvi constructs, but the output inverted the width and height of boxes.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).