8000 MNT: Deprecate date_ticker_factory by oscargus · Pull Request #23081 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

MNT: Deprecate date_ticker_factory #23081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2022
Merged

MNT: Deprecate date_ticker_factory #23081

merged 2 commits into from
May 21, 2022

Conversation

oscargus
Copy link
Member

PR Summary

As discussed in #23013 it may make sense to deprecate date_ticker_factory since AutoDateLocator and AutoDateFormatter has been available for 15-16 years.

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus marked this pull request as ready for review May 20, 2022 07:04
@oscargus oscargus added this to the v3.6.0 milestone May 20, 2022
@oscargus oscargus force-pushed the datetickerfactorydeprecation branch from 8a93858 to 711afeb Compare May 20, 2022 07:13
timhoffm
timhoffm reviewed May 20, 2022
View reviewed changes
jklymak
jklymak approved these changes May 21, 2022
View reviewed changes
Copy link
Member
@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo @timhoffm suggestion...

@oscargus @timhoffm
Update doc/api/next_api_changes/deprecations/23081-OG.rst
56909f4 
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@oscargus
Copy link
Member Author

I merged the suggestion, thanks, so possibly squash and merge.

@timhoffm timhoffm merged commit 037fcca into matplotlib:main May 21, 2022
andrew-fennell pushed a commit to andrew-fennell/matplotlib that referenced this pull request Jun 14, 2022
@oscargus @timhoffm @andrew-fennell
MNT: Deprecate date_ticker_factory (matplotlib#23081)
d796a3e 
* Deprecate date_ticker_factory

* Update doc/api/next_api_changes/deprecations/23081-OG.rst

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
API: changes Maintenance topic: date handling
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oscargus @jklymak @timhoffm
0