8000 MNT: Remove key_press and button_press from FigureManager by greglucas · Pull Request #23079 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

MNT: Remove key_press and button_press from FigureManager #23079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2022
Merged

MNT: Remove key_press and button_press from FigureManager #23079

merged 1 commit into from
May 20, 2022

Conversation

greglucas
Copy link
Contributor

PR Summary

This removes these methods following the deprecation.

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@greglucas greglucas added this to the v3.6.0 milestone May 20, 2022
@greglucas
MNT: Remove key_press and button_press from FigureManager
32835b2 
This removes these methods following the deprecation.
@greglucas greglucas force-pushed the dep-canvas-keypress branch from 961855b to 32835b2 Compare May 20, 2022 02:49
@timhoffm timhoffm merged commit 846864e into matplotlib:main May 20, 2022
@greglucas greglucas deleted the dep-canvas-keypress branch May 20, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@greglucas @QuLogic @timhoffm
0