8000 Make MarkerStyle immutable by timhoffm · Pull Request #22952 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Make MarkerStyle immutable #22952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2022
Merged

Make MarkerStyle immutable #22952

merged 1 commit into from
May 4, 2022

Conversation

timhoffm
Copy link
Member
@timhoffm timhoffm commented May 1, 2022

by removing the deprecated public methods that could modify it.

@timhoffm timhoffm added this to the v3.6.0 milestone May 1, 2022
@timhoffm timhoffm force-pushed the immutable-marker branch from c197c4f to 0b51af6 Compare May 1, 2022 21:22
oscargus
oscargus approved these changes May 2, 2022
View reviewed changes
Copy link
Member
@oscargus oscargus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved subject to the dot. That is, feel free to self-merge once added.

@timhoffm
Make MarkerStyle immutable
aff8a3a 
by removing the deprecated public methods that could modify it.
@timhoffm timhoffm force-pushed the immutable-marker branch from 0b51af6 to aff8a3a Compare May 2, 2022 23:29
@greglucas greglucas merged commit 5e192cc into matplotlib:main May 4, 2022
@timhoffm timhoffm deleted the immutable-marker branch May 4, 2022 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer left review comments

@tacaswell tacaswell tacaswell approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
API: changes Maintenance
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@timhoffm @tacaswell @anntzer @oscargus @greglucas
0