8000 Backport PR #22313 on branch v3.5.x (Fix colorbar exponents) by QuLogic · Pull Request #22844 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Backport PR #22313 on branch v3.5.x (Fix colorbar exponents) #22844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2022
Merged

Backport PR #22313 on branch v3.5.x (Fix colorbar exponents) #22844

merged 1 commit into from
Apr 21, 2022

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Apr 13, 2022

PR Summary

Manual backport of #22313; there were conflicts in lib/matplotlib/axes/_base.py (due to #21398 not being backported), and lib/matplotlib/tests/test_colorbar.py (due to an additional test on main conflicting with the new one here).

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic QuLogic added this to the v3.5.2 milestone Apr 13, 2022
@QuLogic QuLogic added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: color/colorbar labels Apr 13, 2022
@oscargus
Copy link
Member

Not clear what hold for manual back-ports, but if it is enough with a single approval, feel free to self-merge (or inform me and I'll merge).

@QuLogic
Copy link
Member Author
QuLogic commented Apr 14, 2022

One is fine, but I'm hoping @jklymak could confirm on this.

@QuLogic QuLogic requested a review from jklymak April 14, 2022 20:01
jklymak
jklymak approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member
@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK? Sorry to be slow to check it...

@jklymak jklymak merged commit d8629e9 into matplotlib:v3.5.x Apr 21, 2022
@QuLogic QuLogic deleted the auto-backport-of-pr-22313-on-v3.5.x branch April 21, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: color/colorbar
Projects
None yet
Milestone
v3.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @oscargus @jklymak
0