Fix inkscape tests #22768
Merged
Fix inkscape tests #22768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Apr 6, 2022
anntzer
reviewed
Apr 6, 2022
| for stream in filter(None, [self._proc.stdin, | ||
| self._proc.stdout, | ||
| self._proc.stderr]): | ||
| stream.close() |
There was a problem hiding this comment.
Not really a problem, but is it really possible for the process' standard streams to still be open even though the process has terminated? (poll() is not None)
Edit for my personal edification: apparently only communicate() and __exit__() close the streams?
6 tasks
This prevents pytest from failing other test due to auto-closed resources.
Inkscape will fail to create directories in /dev/null, be very unhappy about this, and fail to convent all of the svg.
anntzer
approved these changes
Apr 6, 2022
QuLogic
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This lead me down a several hour rabbit hole, but on Inkscape 1.1.2 (0a00cf5339, 2022-02-04, custom) I need these patches for the test to run locally. I am not convinced that the version of inkscape this is actually the problem though. I updated on March 3 and I only started having trouble with the tests in the last few days. I'm happy to share my pacman logs if someone wants to chase this down.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).