8000 DOC: add job advert by tacaswell · Pull Request #22758 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

DOC: add job advert #22758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Conversation

tacaswell
Copy link
Member

This stick the a box in the location that the template uses for the ads (if you opt into that).

@jklymak
Copy link
Member
jklymak commented Apr 1, 2022

Do we want on the front page as well?

@QuLogic
Copy link
Member
QuLogic commented Apr 1, 2022

It's currently a News item on the front page.

Copy link
Member
@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You have repeated some css from mpl-brochure-site. I wonder if we need to make those coolers available in mpl-sphinx-style?


/* viridis solid colors */
--dark-purple: #440154;
--purple: #482475;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We define these somewhere, I'm pretty sure. Maybe they were moved to mpl-sphinx-theme?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, they're defined in pydata-sphinx-theme; I'm not sure we need all of these.

Copy link
Member
@QuLogic QuLogic Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of the variables actually used below, there is neither --border-radius nor --shadow. There is obviously no --viridis-purple. There is --gray: #6c757d; --gray-dark: #343a40 but not --light-gray, and --blue is instead #007bff.

@tacaswell tacaswell force-pushed the doc_add_job_posting branch from 763b8e1 to 6708267 Compare April 1, 2022 23:06
@tacaswell tacaswell force-pushed the doc_add_job_posting branch from 6708267 to 798fbdc Compare April 1, 2022 23:19
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogic QuLogic added this to the v3.5-doc milestone Apr 1, 2022
@QuLogic QuLogic merged commit 178ed02 into matplotlib:v3.5.1-doc Apr 2, 2022
@tacaswell tacaswell deleted the doc_add_job_posting branch April 2, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
0