8000 Rename confusingly-named cm_fallback. by anntzer · Pull Request #22722 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Rename confusingly-named cm_fallback. #22722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2022
Merged

Rename confusingly-named cm_fallback. #22722

merged 1 commit into from
Mar 29, 2022

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Mar 28, 2022

mathtext can now do fallbacks to fonts other than computer modern, so
the name cm_fallback is outdated. The module is private, so we can
rename the attribute without deprecation.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer
Rename confusingly-named cm_fallback.
a7c7348 
mathtext can now do fallbacks to fonts other than computer modern, so
the name cm_fallback is outdated.  The module is private, so we can
rename the attribute without deprecation.
@tacaswell tacaswell added this to the v3.6.0 milestone Mar 28, 2022
@oscargus
Copy link
Member

Doctest failure seems unrelated (and intermittent), so I merge this.

@oscargus oscargus merged commit d38f93f into matplotlib:main Mar 29, 2022
@anntzer anntzer deleted the cmf branch March 29, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
Maintenance topic: text/mathtext
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @oscargus @timhoffm @tacaswell
0