8000 Small simplification to textpath. by anntzer · Pull Request #22704 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Small simplification to textpath. #22704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2022
Merged

Small simplification to textpath. #22704

merged 1 commit into from
Mar 25, 2022

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Mar 25, 2022
  • verts of glyph_map entries are created with FT2Font.get_path() and are
    thus already arrays; no need to convert them again.
  • We can always extend verts and codes regardless of whether verts1 is
    empty (extend will just be a noop in that case); empty verts should be
    exceptional anyways.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer
Small simplification to textpath.
0f757d2 
- verts of glyph_map entries are created with FT2Font.get_path() and are
  thus already arrays; no need to convert them again.
- We can always extend verts and codes regardless of whether verts1 is
  empty (extend will just be a noop in that case); empty verts should be
  exceptional anyways.
@QuLogic QuLogic added this to the v3.6.0 milestone Mar 25, 2022
@oscargus oscargus merged commit 5971feb into matplotlib:main Mar 25, 2022
@anntzer anntzer deleted the tpg branch March 25, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @oscargus
0