8000 Remove reference to now-deleted reminder note. by anntzer · Pull Request #22658 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Remove reference to now-deleted reminder note. #22658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2022
Merged

Remove reference to now-deleted reminder note. #22658

merged 1 commit into from
Mar 16, 2022

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Mar 16, 2022

The comment was made outdated by ff2d796.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer
Remove reference to now-deleted reminder note.
f9f8e48 
The comment was made outdated by ff2d796.
@tacaswell tacaswell added this to the v3.6.0 milestone Mar 16, 2022
@oscargus
Copy link
Member

I do not want to start a new build for this and do not know of any way to avoid it (as it is just a comment). Feel free to self-merge if you are merging something else and I will try to remember to merge in a similar situation.

@QuLogic
Copy link
Member
QuLogic commented Mar 16, 2022

I assume you're referring to a failing test, but I don't see any now.

@QuLogic QuLogic merged commit 96af8c5 into matplotlib:main Mar 16, 2022
@anntzer anntzer deleted the ur branch March 16, 2022 23:25
@oscargus
Copy link
Member

Was more thinking of avoiding running the CI just for a changed comment.

@QuLogic
Copy link
Member
QuLogic commented Mar 17, 2022

Ah, that's something that could be done with [no ci] in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
Build Maintenance
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @oscargus @QuLogic @tacaswell
0