Remove redundant rcParam-lookup in patches #22511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* No need to lookup rcParam fallback in __init__ as it is done in the set-methods and not used before calling set-methods. * patch.linewidth is a float, so represent default as float.
oscargus
commented
Feb 19, 2022
| @@ -405,8 +401,6 @@ def set_linewidth(self, w): | |||
| """ | |||
| if w is None: | |||
| w = mpl.rcParams['patch.linewidth'] | |||
| if w is None: | |||
There was a problem hiding this comment.
I cannot really see this happening as mpl.rcParams['patch.linewidth'] should never return None. Or have I missed sometihng?
There was a problem hiding this comment.
Correct; the validator says that it must be a float.
QuLogic
approved these changes
Feb 24, 2022
| @@ -405,8 +401,6 @@ def set_linewidth(self, w): | |||
| """ | |||
| if w is None: | |||
| w = mpl.rcParams['patch.linewidth'] | |||
| if w is None: | |||
There was a problem hiding this comment.
Correct; the validator says that it must be a float.
timhoffm
approved these changes
Mar 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor fixes for patches.
done in the set-methods and not used before calling set-methods.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).