8000 Cleanup unused imports and variables in backends by oscargus · Pull Request #22502 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Cleanup unused imports and variables in backends #22502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2022
Merged

Cleanup unused imports and variables in backends #22502

merged 2 commits into from
Feb 23, 2022

Conversation

oscargus
Copy link
Member
@oscargus oscargus commented Feb 19, 2022 •
edited
Loading

PR Summary

Remove unused imports and local variables.

I split some import lines into two: one with the used and one with the unused. In this way, tools will warn if any previously used import becomes unused.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus changed the title Cleanup unused imports and variables Cleanup unused imports and variables in backends Feb 19, 2022
@oscargus oscargus force-pushed the backendcleanup branch 3 times, most recently from 0460a78 to f55fac6 Compare February 19, 2022 11:23
@oscargus oscargus marked this pull request as ready for review February 19, 2022 12:28
anntzer
anntzer reviewed Feb 19, 2022
View reviewed changes
anntzer
anntzer reviewed Feb 19, 2022
View reviewed changes
QuLogic
QuLogic approved these changes Feb 23, 2022
View reviewed changes
@QuLogic QuLogic added this to the v3.6.0 milestone Feb 23, 2022
@oscargus @QuLogic
Apply suggestions from code review
8677681 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@timhoffm timhoffm merged commit 581bf5d into matplotlib:main Feb 23, 2022
@oscargus oscargus deleted the backendcleanup branch February 23, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer left review comments

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

54B2
Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@oscargus @QuLogic @anntzer @timhoffm
0