Clarify error message for bad keyword arguments. #22451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Feb 12, 2022
timhoffm
reviewed
Feb 12, 2022
timhoffm
approved these changes
Feb 14, 2022
`plot([], [], foo=42)` previously emitted ``` 'Line2D' object has no property 'foo' ``` which refers to the Matplotlib-specific concept of "properties". It now instead emits ``` Line2D.set() got an unexpected keyword argument 'foo' ``` which is modeled after the standard error message for unknown keyword arguments. (To maximize backcompat, the implementation goes through a new _internal_update, which does *not* error when the same prop is passed under different aliases. This could be changed later, but is not the goal of this PR.)
timhoffm
approved these changes
Feb 14, 2022
8000
QuLogic
approved these changes
Feb 15, 2022
yuzie007
added a commit
to yuzie007/mpltern
that referenced
this pull request
Feb 19, 2023
While `offset_transform` is introduced since `matplotlib>=3.6.0`, (matplotlib/matplotlib#21965), `transOffset` can still be used. Also, instead of `_internal_update` (matplotlib/matplotlib#22451), `update` can still be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plot([], [], foo=42)previously emittedwhich refers to the Matplotlib-specific concept of "properties". It now
instead emits
which is modeled after the standard error message for unknown keyword
arguments.
(To maximize backcompat, the implementation goes through a new
_internal_update, which does not error when the same prop is passed
under different aliases. This could be changed later, but is not the
goal of this PR.)
(This was triggered by https://discourse.matplotlib.org/t/line2d-object-has-no-property-line-error/22585)
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).