-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Remove some trivial private getters/setters in axisartist #22413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Feb 6, 2022
anntzer
reviewed
Feb 6, 2022
anntzer
approved these changes
Feb 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modulo CI.
<
8000
div data-view-component="true" class="TimelineItem-badge">
720daf4
to
c5febc5
Compare
QuLogic
reviewed
Feb 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least these, based on tests.
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
d61fd3f
to
cd34eb9
Compare
greglucas
approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
_get_offset_radius
/_set_offset_radius
_get_ref_angle
/_set_ref_angle
_get_external_pad
/_set_external_pad
_get_text_ref_angle
and_get_offset_ref_angle
into properties