8000 Remove some trivial private getters/setters in axisartist by timhoffm · Pull Request #22413 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Remove some trivial private getters/setters in axisartist #22413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 12, 2022
Merged

Remove some trivial private getters/setters in axisartist #22413

merged 4 commits into from
Feb 12, 2022

Conversation

timhoffm
Copy link
Member
@timhoffm timhoffm commented Feb 6, 2022

PR Summary

  • Remove trivial private _get_offset_radius / _set_offset_radius
  • Remove trivial private _get_ref_angle / _set_ref_angle
  • Remove trivial private _get_external_pad / _set_external_pad
  • Turn _get_text_ref_angle and _get_offset_ref_angle into properties

@timhoffm timhoffm added this to the v3.6.0 milestone Feb 6, 2022
anntzer
anntzer reviewed Feb 6, 2022
View reviewed changes
anntzer
anntzer reviewed Feb 6, 2022
View reviewed changes
anntzer
anntzer approved these changes Feb 6, 2022
View reviewed changes
Copy link
Contributor
@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo CI.

@timhoffm timhoffm force-pushed the simplify-axisartist branch from 720daf4 to c5febc5 Compare February 6, 2022 17:42
@QuLogic QuLogic closed this Feb 11, 2022
@QuLogic QuLogic reopened this Feb 11, 2022
QuLogic
QuLogic reviewed Feb 11, 2022
View reviewed changes
Copy link
Member
@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least these, based on tests.

@timhoffm timhoffm force-pushed the simplify-axisartist branch from d61fd3f to cd34eb9 Compare February 12, 2022 14:08
@greglucas greglucas merged commit c56edd2 into matplotlib:main Feb 12, 2022
@timhoffm timhoffm deleted the simplify-axisartist branch February 12, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@anntzer anntzer anntzer approved these changes

@greglucas greglucas greglucas approved these changes

Assignees
No one assigned
Labels
Maintenance topic: mpl_toolkit
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@timhoffm @QuLogic @anntzer @greglucas
0