10000 Clarify note in get_cmap() by timhoffm · Pull Request #22396 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Clarify note in get_cmap() #22396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2022
Merged

Clarify note in get_cmap() #22396

merged 1 commit into from
Feb 8, 2022

Conversation

timhoffm
Copy link
Member
@timhoffm timhoffm commented Feb 4, 2022

PR Summary

Closes #22362.

@timhoffm timhoffm added this to the v3.5.2 milestone Feb 4, 2022
@jklymak
Copy link
Member
jklymak commented Feb 5, 2022

@mwaskom is this ok for the original issue?

@mwaskom
Copy link
mwaskom commented Feb 5, 2022

Yep that resolves the ambiguity of the original text. Should the note also flag matplotlib.colormaps? I guess I’m still slightly confused about what the situation will be in 3.6; will there just be 3 different ways to get a copy of a colormap object? (mpl.colormaps, mpl.cm.get_cmap, mpl.cm.<name>)?

@timhoffm
Copy link
Member Author
timhoffm commented Feb 6, 2022 •
edited
Loading

mpl.colormaps will eventually become the default and other cm access methods will be deprecated. However, as long as mpl.colormaps is experimental, I don't want to actively drive people away from mpl.cm.get_cmap. See https://matplotlib.org/stable/users/prev_whats_new/whats_new_3.5.0.html#colormap-registry-experimental for more information.

When the experimental status gets removed, we'll advertise colormaps more loudly.

@QuLogic QuLogic merged commit 5502dee into matplotlib:main Feb 8, 2022
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 8, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 8, 2022
@QuLogic @meeseeksmachine
Backport PR matplotlib#22396: Clarify note in get_cmap()
d515b10
@timhoffm timhoffm deleted the doc-cmap-copy branch February 8, 2022 07:47
timhoffm added a commit that referenced this pull request Feb 8, 2022
@timhoffm
Merge pull request #22427 from meeseeksmachine/auto-backport-of-pr-22…
4988aaf 
…396-on-v3.5.x

Backport PR #22396 on branch v3.5.x (Clarify note in get_cmap())
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.5.2
Development

Successfully merging this pull request may close these issues.

[Doc]: Deprecation note in get_cmap is non-actionable
4 participants
@timhoffm @jklymak @mwaskom @QuLogic
0