FIX: repositioning axes labels: use get_window_extent instead for spines. #22301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
commented
Jan 24, 2022
| @@ -2081,8 +2081,9 @@ def _update_label_position(self, renderer): | |||
| if self.label_position == 'bottom': | |||
| try: | |||
| spine = self.axes.spines['bottom'] | |||
| spinebbox = spine.get_transform().transform_path( | |||
| spine.get_path()).get_extents() | |||
There was a problem hiding this comment.
OK, so this is actually a behaviour change on bare axes. OTOH I think it is correct. get_path() will not include the ticks, whereas get_window_extent does. For axes with labels, this doesn't matter because the tick labels dominate. However, for an axes with no tick labels and long ticks, this spacing will be wrong.
Apparently we only test this in one spot, because it is a bit odd to label an axes with not tick labels...
There was a problem hiding this comment.
Note in the changed image how the "ylabel" on the second axes has moved to the left a little bit.
Not sure if this is worth an API change note...
3f1cdb9 to
c0a78bd
Compare
tacaswell
approved these changes
Jan 24, 2022
QuLogic
approved these changes
Jan 25, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 25, 2022
…_window_extent instead for spines.
QuLogic
added a commit
that referenced
this pull request
Jan 25, 2022
…301-on-v3.5.x Backport PR #22301 on branch v3.5.x (FIX: repositioning axes labels: use get_window_extent instead for spines.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #22300
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).