Remove Axes sublists from docs #22279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Jan 21, 2022
Comment on lines
35
to
41
| # Adding from the top matches the legend without have to explicitly re-order | ||
| # the legend. | ||
| for j, height in enumerate(reversed(approved_ratios)): | ||
| bottom -= height | ||
| bc = ax2.bar(0, height, width, bottom=bottom, color='C0', | ||
| alpha=0.1 + 0.25 * j) | ||
| ax2.bar_label(bc, labels=["%d%%" % (height * 100,)], label_type='center') |
There was a problem hiding this comment.
This breaks the association of approved_ratios to the legend labels.
Anyway, legend(labels) is a bad idea because you rely on the insertion order of artists.
I suggest you do
age_ratios = [.33, .54, .07, .06]
age_labels = ['Under 35', '35-49', '50-65', 'Over 65']
for j, height, label in ...:
....
ax2.bar(..., label=label)
ax2.legend()
There was a problem hiding this comment.
I'm not sure what you mean about breaking the association, but I applied the change anyway.
... by saving and using the results from Axes method calls. Also, replace the colour palette in the bar chart.
6c2e79b to
88433b8
Compare
timhoffm
approved these changes
Jan 25, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 25, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 25, 2022
QuLogic
added a commit
that referenced
this pull request
Jan 25, 2022
…279-on-v3.5.1-doc Backport PR #22279 on branch v3.5.1-doc (Remove Axes sublists from docs)
QuLogic
added a commit
that referenced
this pull request
Jan 27, 2022
…279-on-v3.5.x Backport PR #22279 on branch v3.5.x (Remove Axes sublists from docs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
There are some bits of the tutorials that should have been changed to remove reference to modifying the Axes sublists.
Also remove the use of the sublists in the 'bar of pie' example, and improve its colours.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).