Merge "Scatter Symbol" and "Scatter Custom Symbol" examples #22276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1733ce1 to
d345624
Compare
Remove "Scatter plot with pie chart markers". This is only a variant of path-as-custom-symbol, which is already covered here. Also, all pie markers in the scatter plot have the same data distribution, so the pie is more a style thing and cannot convey additional datapoint-specific information. Also closes matplotlib#22266 by using *sizes* instead of *s* and spelling out the color to make their meaning clearer.
d345624 to
cbbebe2
Compare
oscargus
approved these changes
Feb 22, 2022
|
FWIW there's also https://matplotlib.org/stable/gallery/lines_bars_and_markers/scatter_star_poly.html. Perhaps also link to https://matplotlib.org/stable/gallery/lines_bars_and_markers/marker_reference.html (which is more general and warrants being separate)? |
|
Yes, but I don‘t have the time to work 8000 on this for now. Therefore I prefer to merge as is. Feel free to amend or open an issue so that we don‘t forget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge "Scatter Symbol" and "Scatter Custom Symbol" examples.
Remove "Scatter plot with pie chart markers". This is only a variant of
path-as-custom-symbol, which is already covered here. Also, all pie
markers in the scatter plot have the same data distribution, so the
pie is more a style thing and cannot convey additional
datapoint-specific information.
Also closes #22266 by using sizes instead of s and spelling out the
color to make their meaning clearer.