8000 Fix Qt enum access. by anntzer · Pull Request #22265 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix Qt enum access. #22265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2022
Merged

Fix Qt enum access. #22265

merged 1 commit into from
Jan 19, 2022

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jan 19, 2022

This was missed in the global fixing of enums for PyQt6 (now using
_enum everywhere). To trigger, try to interactively save a figure but
input an invalid format, e.g. "foo.bar".

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer
Fix Qt enum access.
76cb7c9 
This was missed in the global fixing of enums for PyQt6 (now using
_enum everywhere).  To trigger, try to interactively save a figure but
input an invalid format, e.g. "foo.bar".
@anntzer anntzer added this to the v3.5.2 milestone Jan 19, 2022
@tacaswell tacaswell merged commit c78cf12 into matplotlib:main Jan 19, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 19, 2022
@tacaswell @meeseeksmachine
Backport PR matplotlib#22265: Fix Qt enum access.
9516e84
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 19, 2022
Merged
@anntzer anntzer deleted the qe branch January 19, 2022 22:02
QuLogic added a commit that referenced this pull request Jan 20, 2022
@QuLogic
Merge pull request #22269 from meeseeksmachine/auto-backport-of-pr-22…
8f40942 
…265-on-v3.5.x

Backport PR #22265 on branch v3.5.x (Fix Qt enum access.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: Qt
Projects
None yet
Milestone
v3.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @tacaswell
0