8000 Right-aligned status text in backends by oscargus · Pull Request #22110 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Right-aligned status text in backends #22110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2022
Merged

Right-aligned status text in backends #22110

merged 1 commit into from
Jan 5, 2022

Conversation

oscargus
Copy link
Member
@oscargus oscargus commented Jan 5, 2022 •
edited
Loading

PR Summary

Closes #22012

Not clear how to add a test for it.

Also, should this be documented with a "what's new"? Seems quite marginal...

(I couldn't figure out how the macosx-version worked, and do not have a mac to test it...)

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus mentioned this pull request Jan 5, 2022
Closed
anntzer
anntzer approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor
@anntzer anntzer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
I don't think this is particularly testable (other than manually).

@dstansby dstansby added this to the v3.6.0 milestone Jan 5, 2022
@dstansby dstansby merged commit 7549f8c into matplotlib:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Mouseover coordinate/value text should be right aligned
3 participants
@oscargus @anntzer @dstansby
0