Share FigureManager class between gtk3 and gtk4. #22079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Jan 11, 2022
QuLogic
approved these changes
Jan 12, 2022
greglucas
reviewed
Jan 29, 2022
| """ | ||
|
|
||
| def __init__(self, canvas, num): | ||
| gtk_ver = Gtk.get_major_version() |
There was a problem hiding this comment.
Suggested change
| gtk_ver = Gtk.get_major_version() | |
| self._gtk_ver = Gtk.get_major_version() |
Do you want to store this on the manager so you can reuse it below instead of calling this method in other functions too?
The gtk version checks are not the nicest, but sharing most of the setup code between gtk3 and gtk4 still seems worthwhile? (Note that on gtk3, it is explicitly OK to not bother to destroy the vbox and toolbar, as gtk3 always destroys child widgets upon parent destruction.)
greglucas
approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gtk version checks are not the nicest, but sharing most of the setup
code between gtk3 and gtk4 still seems worthwhile?
(Note that on gtk3, it is explicitly OK to not bother to destroy the
vbox and toolbar, as gtk3 always destroys child widgets upon parent
destruction.)
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).