Refactor common parts of ImageMagick{,File}Writer. #21955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Dec 15, 2021
ImageMagickWriter previously did not support frame_format = "raw", unlike ImageMagickFileWriter, because it did not normalize it to "rgba". (To test this, start e.g. with the simple_anim.py example, set the writer to an ImageMagickWriter (or ImageMagickFileWriter) and additionally set writer.frame_format = "raw".) Also deprecate the ``delay`` and ``output_args`` properties which can directly be handled by ``_args``, but add an ``input_names`` property which allows the different customization between ImageMagickWriter and ImageMagickFileWriter.
QuLogic
approved these changes
Dec 15, 2021
tacaswell
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageMagickWriter previously did not support frame_format = "raw",
unlike ImageMagickFileWriter, because it did not normalize it to "rgba".
(To test this, start e.g. with the simple_anim.py example, set the
writer to an ImageMagickWriter (or ImageMagickFileWriter) and
additionally set writer.frame_format = "raw".)
Also deprecate the
delayandoutput_argsproperties which candirectly be handled by
_args, but add aninput_namespropertywhich allows the different customization between ImageMagickWriter and
ImageMagickFileWriter.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).