8000 Slightly cleanup RendererBase docs. by anntzer · Pull Request #21947 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Slightly cleanup RendererBase docs. #21947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2021
Merged

Slightly cleanup RendererBase docs. #21947

merged 2 commits into from
Dec 15, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Dec 14, 2021

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

dstansby
dstansby approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member
@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to take or leave my comment, and then self merge

lib/matplotlib/backend_bases.py Outdated
Helper method (along with :meth:`_iter_collection`) to implement
:meth:`draw_path_collection` in a space-efficient manner.
Helper method (along with `_iter_collection`) to implement
`draw_path_collection` in a space-efficient manner.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`draw_path_collection` in a space-efficient manner.
`draw_path_collection` in a memory-efficient manner.

Perhaps? Maybe "space-efficient" has a context-specific meaning that I don't know and is fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edited.

@anntzer
Copy link
Contributor Author
anntzer commented Dec 15, 2021

Self-merging per @dstansby's comment.

@anntzer anntzer added this to the v3.6.0 milestone Dec 15, 2021
@anntzer anntzer merged commit cb483fc into matplotlib:main Dec 15, 2021
@anntzer anntzer deleted the bbdoc branch December 15, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @dstansby
0