8000 Small `__getstate__` cleanups. by anntzer · Pull Request #21936 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Small __getstate__ cleanups. #21936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2021
Merged

Small __getstate__ cleanups. #21936

merged 1 commit into from
Dec 14, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Dec 13, 2021

Remove outdated comment in AxesBase.__getstate__ (we don't cache the
renderer on it anymore).

Remove unnecessary SubplotSpec.__getstate__ (it has become unnecessary
now that SubplotSpec doesn't hold onto layoutbox/poslayoutbox anymore.)

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer
Small __getstate__ cleanups.
1f30016 
Remove outdated comment in `AxesBase.__getstate__` (we don't cache the
renderer on it anymore).

Remove unnecessary `SubplotSpec.__getstate__` (it has become unnecessary
now that SubplotSpec doesn't hold onto layoutbox/poslayoutbox anymore.)
@timhoffm timhoffm added this to the v3.6.0 milestone Dec 14, 2021
@timhoffm timhoffm merged commit 9221d66 into matplotlib:main Dec 14, 2021
@anntzer anntzer deleted the gs branch December 14, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants 3526
@anntzer @QuLogic @timhoffm
0