Fold _rgbacache into _imcache. #21910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both caches are used when converting images to rgba; the only difference is that rgbacache was specifically used for PcolorImage (via PcolorImage.make_image) whereas imcache covered the rest (via _ImageBase._make_image). One can instead use a single attribute (also avoiding to duplicate their invalidation). Also update the comment, and a bit the implementation, on `__getstate__`: a long time ago imcache was (probably?) a non-picklable custom subclass; now it is picklable but it still makes sense not to pickle it.
greglucas
approved these changes
Dec 13, 2021
QuLogic
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both caches are used when converting images to rgba; the only difference
is that rgbacache was specifically used for PcolorImage (via
PcolorImage.make_image) whereas imcache covered the rest (via
_ImageBase._make_image). One can instead use a single attribute (also
avoiding to duplicate their invalidation).
Also update the comment, and a bit the implementation, on
__getstate__: a long time ago imcache was (probably?) a non-picklablecustom subclass; now it is picklable but it still makes sense not to
pickle it.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).