10000 Include test notebooks in test package by QuLogic · Pull Request #21900 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Include test notebooks in test package #21900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2021
Merged

Include test notebooks in test package #21900

merged 1 commit into from
Dec 10, 2021

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Dec 10, 2021

PR Summary

Additionally, the test requires nbconvert to execute, and ipykernel as the Python 3 kernel.

A redo of #21665.
Fixes #21654

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic
Include test notebooks in test package
59ac2a1 
Additionally, the test requires `nbconvert` to execute, and `ipykernel`
as the Python 3 kernel.
@QuLogic QuLogic added this to the v3.5.1 milestone Dec 10, 2021
@dstansby dstansby merged commit 085fdd0 into matplotlib:main Dec 10, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 10, 2021
@dstansby @meeseeksmachine
Backport PR matplotlib#21900: Include test notebooks in test package
b73cf46
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 10, 2021
Merged
@QuLogic QuLogic deleted the test-notebook branch December 10, 2021 10:11
dstansby added a commit that referenced this pull request Dec 10, 2021
@dstansby
Merge pull request #21912 from meeseeksmachine/auto-backport-of-pr-21…
c4ce5d0 
…900-on-v3.5.x

Backport PR #21900 on branch v3.5.x (Include test notebooks in test package)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.5.1
Development

Successfully merging this pull request may close these issues.

[Bug]: test_nbagg_01.ipynb not installed
3 participants
@QuLogic @jklymak @dstansby
0