Drop retina images when building PDF docs #21890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doubles the size of the PDF, and makes it impossible to upload to GitHub Pages.
d428276 to
ad9fe72
Compare
dstansby
approved these changes
Dec 9, 2021
timhoffm
approved these changes
Dec 9, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 9, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 9, 2021
timhoffm
added a commit
that referenced
this pull request
Dec 9, 2021
…890-on-v3.5.x Backport PR #21890 on branch v3.5.x (Drop retina images when building PDF docs)
timhoffm
added a commit
that referenced
this pull request
Dec 9, 2021
…890-on-v3.5.0-doc Backport PR #21890 on branch v3.5.0-doc (Drop retina images when building PDF docs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This doubles the size of the PDF, and makes it impossible to upload to GitHub Pages.
In the future, I will make the images vectorized, but this requires work in sphinx-gallery or some rather large hacks.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).