8000 DOC: Simplify markevery demo by timhoffm · Pull Request #21862 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

DOC: Simplify markevery demo #21862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2021
Merged

DOC: Simplify markevery demo #21862

merged 1 commit into from
Dec 16, 2021

Conversation

timhoffm
Copy link
Member
@timhoffm timhoffm commented Dec 5, 2021
  • Reword description
  • Remove non-distinguishing examples: We don't need three float
    examples, (0.0, 0.1) is the same as 0.1.
  • This makes for 9 cases, which can be laid out easily in a 3x3 grid,
    so we don't need axes calculation and removal logic.

@timhoffm timhoffm added this to the v3.5-doc milestone Dec 5, 2021
jklymak
jklymak reviewed Dec 5, 2021
View reviewed changes
Copy link
Member
@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great... A few suggested changes, and maybe an addition.

jklymak
jklymak approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member
@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to take or leave the small suggestions - its already an improvement. If you don't take them feel free to self merge, if you do take them, feel free to self merge after CI....

@timhoffm
DOC: Simpify markevery demo
78827b7 
- Reword description
- Remove non-distinguishing examples: We don't need three float
  examples, (0.0, 0.1) is the same as 0.1.
- This makes for 9 cases, which can be laid out easily in a 3x3 grid,
  so we don't need axes calculation and removal logic.
@timhoffm timhoffm force-pushed the doc-markevery-demo branch 2 times, most recently from cc36bc4 to 78827b7 Compare December 16, 2021 20:13
@timhoffm timhoffm merged commit 9df76e2 into matplotlib:main Dec 16, 2021
@timhoffm timhoffm deleted the doc-markevery-demo branch December 16, 2021 23:02
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 16, 2021
@timhoffm @meeseeksmachine
Backport PR matplotlib#21862: DOC: Simpify markevery demo
17929e0
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 16, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 16, 2021
@timhoffm @meeseeksmachine
Backport PR matplotlib#21862: DOC: Simpify markevery demo
f16efc0
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 16, 2021
Merged
@QuLogic QuLogic changed the title DOC: Simpify markevery demo DOC: Simplify markevery demo Dec 17, 2021
QuLogic added a commit that referenced this pull request Dec 17, 2021
@QuLogic
Merge pull request #21987 from meeseeksmachine/auto-backport-of-pr-21…
d912ccc 
…862-on-v3.5.x

Backport PR #21862 on branch v3.5.x (DOC: Simplify markevery demo)
QuLogic added a commit that referenced this pull request Dec 17, 2021
@QuLogic
Merge pull request #21988 from meeseeksmachine/auto-backport-of-pr-21…
ad96908 
…862-on-v3.5.1-doc

Backport PR #21862 on branch v3.5.1-doc (DOC: Simplify markevery demo)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.5-doc
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @jklymak @QuLogic
0