8000 Fix streamline plotting from upper edges of grid by dstansby · Pull Request #21859 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix streamline plotting from upper edges of grid #21859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2021
Merged

Fix streamline plotting from upper edges of grid #21859

merged 1 commit into from
Dec 9, 2021

Conversation

dstansby
Copy link
Member
@dstansby dstansby commented Dec 4, 2021 •
edited
Loading

PR Summary

Fixes #21649. See the added comment for info and motivation.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

8000
@dstansby dstansby added this to the v3.5.1 milestone Dec 4, 2021
@dstansby
Copy link
Member Author
dstansby commented Dec 4, 2021

The fixed bug is illustrated rather nicely in the new test image!

@dstansby dstansby marked this pull request as ready for review December 4, 2021 12:35
@jklymak
Copy link
Member
jklymak commented Dec 4, 2021

Yes, the image does a good job, but given that we have indexing errors like this, would you consider starting from the other edges as well?

@dstansby
Copy link
Member Author
dstansby commented Dec 4, 2021

Yes, the image does a good job, but given that we have indexing errors like this, would you consider starting from the other edges as well?

As in adding streamlines drawn from around the edges to the figure test?

@jklymak
Copy link
Member
jklymak commented Dec 4, 2021

Yep, just some more lines.

@dstansby
Copy link
Member Author
dstansby commented Dec 5, 2021

👍 done. Is it worth getting rid of the pdf and svg test images at the same time too?

@jklymak
Copy link
Member
jklymak commented Dec 5, 2021

I would unless we are testing something with them.

@jklymak
Copy link
Member
jklymak commented Dec 5, 2021

One of the dots doesn't have a line. Is that expected because it is close to an existing line?

@dstansby
Copy link
Member Author
dstansby commented Dec 5, 2021

One of the dots doesn't have a line. Is that expected because it is close to an existing line?

Yes, that's correct.

I've removed the pdf/svg images, and also removed the tolerance that was on this test before to see if we can do without it.

@QuLogic QuLogic merged commit e9cbd9d into matplotlib:main Dec 9, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 9, 2021
@QuLogic @meeseeksmachine
Backport PR matplotlib#21859: Fix streamline plotting from upper edge…
f996859 
…s of grid
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 9, 2021
Merged
QuLogic added a commit that referenced this pull request Dec 10, 2021
@QuLogic
Merge pull request #21899 from meeseeksmachine/auto-backport-of-pr-21…
0d36f3f 
…859-on-v3.5.x

Backport PR #21859 on branch v3.5.x (Fix streamline plotting from upper edges of grid)
@dstansby dstansby deleted the streamline-edges branch December 10, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.1
Development

Successfully merging this pull request may close these issues.

[Bug]: Startpoints in streamplot fail on right and upper edges
3 participants
@dstansby @jklymak @QuLogic
0