8000 Don't hide build log on GHA. by anntzer · Pull Request #21766 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Don't hide build log on GHA. #21766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2021
Merged

Don't hide build log on GHA. #21766

merged 1 commit into from
Nov 27, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Nov 26, 2021

The log is useful even on success, e.g. to check for warnings. It is
also consistent with what's already being done on Azure Pipelines.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer
Don't hide build log on GHA.
c18f7fd 
The log is useful even on success, e.g. to check for warnings.  It is
also consistent with what's already being done on Azure Pipelines.
@anntzer anntzer added the Build label Nov 26, 2021
@tacaswell tacaswell merged commit c3655a3 into matplotlib:main Nov 27, 2021
@tacaswell tacaswell added this to the v3.6.0 milestone Nov 27, 2021
@anntzer anntzer deleted the ve branch November 27, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @tacaswell
0