8000 MNT: Clean up some UTF strings and memory autorelease by greglucas · Pull Request #21756 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

MNT: Clean up some UTF strings and memory autorelease #21756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

MNT: Clean up some UTF strings and memory autorelease #21756

wants to merge 1 commit into from

Conversation

greglucas
Copy link
Contributor

PR Summary

Use UTF-8 strings instead of C strings with encodings.

Use autorelease semantics instead of explicitly keeping track of this ourselves and releasing.

Closes #21722

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@greglucas
MNT: Clean up some UTF strings and memory autorelease
955054a 
Use UTF-8 strings instead of C strings with encodings.

Use autorelease semantics instead of explicitly releasing.
@greglucas greglucas added this to the v3.6.0 milestone Nov 25, 2021
@jklymak jklymak marked this pull request as draft May 18, 2022 06:59
@jklymak
Copy link
Member
jklymak commented May 18, 2022

Feel free to move from draft when rebased....

@greglucas greglucas mentioned this pull request Aug 4, 2022
Merged
4 tasks
@QuLogic
Copy link
Member
QuLogic commented Aug 5, 2022

If I understood @greglucas correctly, this is replaced by #23060 and #23558.

@QuLogic QuLogic closed this Aug 5, 2022
@greglucas
Copy link
Contributor Author

Yes, I meant to close, thanks for cleaning it up for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
GUI: MacOSX status: needs rebase status: orphaned PR status: superseded
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

[MNT]: Is the macosx backend (very slowly) leaking strings?
4 participants
@greglucas @jklymak @QuLogic @dstansby
0