10000 Update gitattributes so that objc diffs are correctly contextualized. by anntzer · Pull Request #21754 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Update gitattributes so that objc diffs are correctly contextualized. #21754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2021
Merged

Update gitattributes so that objc diffs are correctly contextualized. #21754

merged 1 commit into from
Nov 26, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Nov 25, 2021

i.e., when showing a diff on _macosx.m, the @@ ... header shows the
correct current function.

Split out of #16931.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer
Update gitattributes so that objc diffs are correctly contextualized.
3d95af1 
i.e., when showing a diff on _macosx.m, the `@@ ...` header shows the
correct current function.
@QuLogic QuLogic added this to the v3.6.0 milestone Nov 26, 2021
@QuLogic QuLogic merged commit d96a0e4 into matplotlib:main Nov 26, 2021
@anntzer anntzer deleted the attr branch November 26, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm
0