8000 Add a helper for directly output pdf streams. by anntzer · Pull Request #21752 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Add a helper for directly output pdf streams. #21752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2021
Merged

Add a helper for directly output pdf streams. #21752

merged 1 commit into from
Nov 26, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Nov 25, 2021

Also, such directly output streams don't need an explicitly set Length,
as the stream outputter will fill in that entry itself. This is why
e.g. the invalid entry for toUnicodeMapObject (where Length was set to
unicode_cmap rather than len(unicode_cmap)) was not a problem: it was
overwritten in endStream().

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer
Add a helper for directly output pdf streams.
1921fef 
Also, such directly output streams don't need an explicitly set Length,
as the stream outputter will fill in that entry itself.  This is why
e.g. the invalid entry for toUnicodeMapObject (where Length was set to
unicode_cmap rather than len(unicode_cmap)) was not a problem: it was
overwritten in endStream().
@tacaswell tacaswell added this to the v3.6.0 milestone Nov 25, 2021
@timhoffm timhoffm merged commit 161ec4a into matplotlib:main Nov 26, 2021
@anntzer anntzer deleted the pdfstream branch November 26, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
backend: pdf Maintenance
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @timhoffm
0