8000 Fix compiler configuration priority for FreeType build by QuLogic · Pull Request #21720 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix compiler configuration priority for FreeType build #21720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2021
Merged

Fix compiler configuration priority for FreeType build #21720

merged 1 commit into from
Nov 23, 2021

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Nov 22, 2021

PR Summary

The CC/CFLAGS/etc flags from the Python config should be our default, but we should always listen to an existing CC set in the environment.

Fixes conda-forge/matplotlib-feedstock#312 (comment)

PR Checklist

Tests and Styling

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic
Fix compiler configuration priority for FreeType build
57b749f 
The CC/CFLAGS/etc flags from the Python config should be our default,
but we should always listen to an existing CC set in the environment.

Fixes conda-forge/matplotlib-feedstock#312 (comment)
@QuLogic QuLogic added the Build label Nov 22, 2021
@QuLogic QuLogic added this to the v3.5.1 milestone Nov 22, 2021
dopplershift
dopplershift approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor
@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this fixes the conda-forge build.

@dopplershift dopplershift merged commit d114546 into matplotlib:main Nov 23, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 23, 2021
@dopplershift @meeseeksmachine
Backport PR matplotlib#21720: Fix compiler configuration priority for…
abcd750 
… FreeType build
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 23, 2021
Merged
@QuLogic QuLogic deleted the fix-ft-env branch November 23, 2021 00:36
QuLogic added a commit that referenced this pull request Nov 23, 2021
@QuLogic
Merge pull request #21721 from meeseeksmachine/auto-backport-of-pr-21…
d09703b 
…720-on-v3.5.x

Backport PR #21720 on branch v3.5.x (Fix compiler configuration priority for FreeType build)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
v3.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @dopplershift @anntzer
0